fix: preserve custom Zstd level checkbox state in edit dialog - #129
Merged
Conversation
UpdateCompressionLevelState() ran after CustomZstdLevelBox.IsChecked was set to true, and its Checked handler immediately unchecked the box because CompressionLevelRow was still disabled from the earlier no-image-path default. Reordering so the row state is refreshed first lets the checkbox stick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiskOptions.CustomZstdLeveland the compression preset persisted correctly.CreateDiskDialog's edit constructor setCustomZstdLevelBox.IsChecked = truebefore callingUpdateCompressionLevelState(). TheCheckedhandler fires synchronously and immediately unchecked the box becauseCompressionLevelRow.IsEnabledwas stillfalse(stale from the base constructor, beforeImagePathBox.Textwas populated).UpdateCompressionLevelState()right after settingImagePathBox/CompressionLevelBox, before settingCustomZstdLevelBox.IsChecked, so the row is already enabled when the checkbox event fires.Test plan
dotnet build