fix(core): disable comment health for INI and C# Designer - #41
Merged
Conversation
INI is a data/config format like YAML/JSON/TOML/XML, and C# Designer files are auto-generated with no hand-written comments, so comment-density analysis is not meaningful for either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShowHealth = falseon the INI language entry, matching other data/config formats (YAML, JSON, TOML, XML) where comment-density analysis isn't meaningful.ShowHealth = falseon the C# Designer entry (*.designer.cs), since these files are auto-generated and rarely contain hand-written comments — mirrors the existingMSBuild scriptentry.Test plan
dotnet build Sloc.slnxsucceedsdotnet test tests/Sloc.Core.Tests --filter "FullyQualifiedName~LanguageRegistry"passes (68/68)