RFC: Add Arch Linux support and a bunch of minor fixes - #2
Open
bjorn-oivind wants to merge 1 commit into
Open
Conversation
This adds Arch Linux support to the module, fixes some inconsistent indentation and white space damage, adds a new parameter to avoid hardcoding the base directory to somewhere under /srv, fixes the environment when running the buildout and makes sure that supervisord only runs once (although it depends on the supervisord socket being placed in var/supervisor.sock under the buildout directory.)
Member
Member
|
We don't have anyone on the installer team that works with puppet, and nobody's suggested it's a priority. I think we should move this repo to the collective. |
Member
|
ok, i'll move it if @eleddy is fine with the move. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent some time working on these manifests to make them work for my particular platform and buildroot. Let me begin by saying that I'm sorry that the commit is a bit of a mess which touches everything - I sort of just made the changes as errors popped up or when I noticed something off around the are where I was already editing.
The primary aim of the changes was to add Arch Linux support. I also changed the way /var was handled (replaced it with a new parameter) and added a "creates" statement to the supervisord to avoid having puppet spawning multiple instances. Not too happy about that last one, since it depends on having the correct socket location in the buildroot, and I don't know plone or buildouts well enough to say what the common idiom is.
Please consider this merge request a RFC and feel free to nag about the patch.
On an unrelated note - is there any plans to add the module to the puppet forge?