Conversation
…nner status The internal/provider package was built resource-by-resource, which left ~100 lines of copied boilerplate across 12 files: the Configure client assertion, the `errors.As(err, &apiErr) && StatusCode == 404` check, inline runner-status types.Object construction, and manual RunnerManagerID null checks. Each copy had to be kept in sync by hand. Extract four tiny helpers in helpers.go and replace all call sites: - clientFromProviderData: one helper serves both resource and datasource Configure (both expose ProviderData and Diagnostics). - isAPINotFound: replaces 13 repeated 404 checks. - runnerStatusObjectValue + shared runnerStatusAttrTypes: replaces 3 copies of the same four-field status ObjectValue construction. - Reuse existing stringValueOrNull for three RunnerManagerID sites. Also tighten stringListValue to use ListValueMust with []attr.Value, skipping the reflection pass ListValueFrom performs over the typed slice (and dropping a bogus context.Background()). No behaviour changes, no schema changes. Existing tests pass unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nner status
The internal/provider package was built resource-by-resource, which left ~100 lines of copied boilerplate across 12 files: the Configure client assertion, the
errors.As(err, &apiErr) && StatusCode == 404check, inline runner-status types.Object construction, and manual RunnerManagerID null checks. Each copy had to be kept in sync by hand.Extract four tiny helpers in helpers.go and replace all call sites:
Also tighten stringListValue to use ListValueMust with []attr.Value, skipping the reflection pass ListValueFrom performs over the typed slice (and dropping a bogus context.Background()).
No behaviour changes, no schema changes. Existing tests pass unchanged.