Skip to content

fix: rocksdb DeleteSync#281

Merged
swift1337 merged 1 commit intocometbft:mainfrom
songgaoye:fix_rocksdb_delete_sync
Jan 26, 2026
Merged

fix: rocksdb DeleteSync#281
swift1337 merged 1 commit intocometbft:mainfrom
songgaoye:fix_rocksdb_delete_sync

Conversation

@songgaoye
Copy link
Copy Markdown
Contributor

@songgaoye songgaoye commented Jan 23, 2026


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)

Note

Fixes error handling in rocksdb.go

  • DeleteSync now returns the underlying error from db.db.Delete(db.woSync, key) rather than nil, ensuring delete failures are surfaced to callers.

Written by Cursor Bugbot for commit 97d6bec. This will update automatically on new commits. Configure here.

@songgaoye songgaoye requested review from a team as code owners January 23, 2026 03:59
@songgaoye songgaoye changed the title fix rocksdb DeleteSync fix: rocksdb DeleteSync Jan 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 26, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.41%. Comparing base (fb4f703) to head (97d6bec).
⚠️ Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
rocksdb.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   76.80%   78.41%   +1.60%     
==========================================
  Files          23       23              
  Lines        2048     1700     -348     
==========================================
- Hits         1573     1333     -240     
+ Misses        403      294     -109     
- Partials       72       73       +1     
Files with missing lines Coverage Δ
rocksdb.go 73.45% <0.00%> (+1.39%) ⬆️

... and 21 files with indirect coverage changes

Files with missing lines Coverage Δ
rocksdb.go 73.45% <0.00%> (+1.39%) ⬆️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@swift1337 swift1337 added this pull request to the merge queue Jan 26, 2026
Merged via the queue into cometbft:main with commit c9122e2 Jan 26, 2026
8 of 12 checks passed
@songgaoye songgaoye deleted the fix_rocksdb_delete_sync branch January 27, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants