Skip to content

fix: prevent PrefixDB from closing underlying DB and copying prefix #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swift1337 merged 4 commits into from
Jan 27, 2026
Merged

fix: prevent PrefixDB from closing underlying DB and copying prefix #283

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e6ca4b
fix: prevent PrefixDB from closing underlying DB and copying prefix
songgaoye Jan 23, 2026
5052f32
Merge branch 'main' into fix_prefixdb_flaw
songgaoye Jan 27, 2026
aa97824
fix lint
songgaoye Jan 27, 2026
c67e67e
fix lint
songgaoye Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions prefixdb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var _ DB = (*PrefixDB)(nil)
// NewPrefixDB lets you namespace multiple DBs within a single DB.
func NewPrefixDB(db DB, prefix []byte) *PrefixDB {
return &PrefixDB{
prefix: prefix,
prefix: cp(prefix),
db: db,
}
}
Expand Down Expand Up @@ -160,11 +160,10 @@ func (pdb *PrefixDB) NewBatch() Batch {
}

// Close implements DB.
func (pdb *PrefixDB) Close() error {
pdb.mtx.Lock()
defer pdb.mtx.Unlock()

return pdb.db.Close()
func (*PrefixDB) Close() error {
// PrefixDB doesn't own the underlying database, so Close is a no-op.
// The underlying DB should be closed by its owner, not by prefix wrappers.
return nil
}

// Print implements DB.
Expand Down
Loading