car_helpers: compare VIN with != instead of is not#3524
Open
Jiming-C wants to merge 1 commit into
Open
Conversation
VIN_UNKNOWN is a string ("0" * 17), so `carVin is not VIN_UNKNOWN` checks
object identity rather than value. A carVin read back from cached CarParams
is a different object, so the guard is effectively always true and an unknown
cached VIN is treated as valid. Use != to compare by value as intended.
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. ✅ No changes detected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VIN_UNKNOWNis a string ("0" * 17), socarVin is not VIN_UNKNOWNchecks object identity rather than value. AcarVinread back from a cachedCarParamsis a different object, so the guard is effectively always true and an unknown cached VIN gets treated as valid. Use!=to compare by value as intended.Validation