fix(ca): improve Canadian provincial holiday rules - #635
Merged
Conversation
KristjanESPERANTO
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While comparing opening_hours.js and date-holidays, I noticed a few differences in the Canadian holiday data, so I did some primary-source checking and adjusted the confirmed cases.
I took another pass over the Canada data and checked a few more province-specific rules and sources. That led to a few more follow-up cleanups, mainly to avoid modeling certain holidays too broadly at the national level.
In particular, this now tightens the provincial handling for Thanksgiving, Victoria Day, Boxing Day, the August holiday, and Remembrance Day, removes national Easter Sunday, and keeps the Quebec-specific handling around National Patriots' Day and the Good Friday/Easter Monday choice.
This makes the CA data more precise.