Skip to content

Victoria, Australia school holidays - #637

Open
clmcavaney wants to merge 3 commits into
commenthol:masterfrom
clmcavaney:vic-school-holidays
Open

Victoria, Australia school holidays#637
clmcavaney wants to merge 3 commits into
commenthol:masterfrom
clmcavaney:vic-school-holidays

Conversation

@clmcavaney

Copy link
Copy Markdown

Adding Victorian school holidays.
Note: For 2026 only

@clmcavaney clmcavaney changed the title Victorian school holidays Victoria, Australia school holidays Jul 18, 2026
@commenthol

Copy link
Copy Markdown
Owner

Hi @clmcavaney,
Can you please fix the tabs in the yaml file? npm run lint -- --fix will do the trick.
Furthermore we'd need to have test fixtures being generated.
Please check the CONTRIBUTING.md file.

@clmcavaney

Copy link
Copy Markdown
Author

Thanks @commenthol - I've fixed the tabs.
Also double checked the CONTRIBUTING.md steps.
All tests pass and the text fixtures are generated correctly.

@clmcavaney
clmcavaney force-pushed the vic-school-holidays branch from 53fd931 to dd85700 Compare July 26, 2026 22:46
@clmcavaney clmcavaney closed this Jul 26, 2026
@clmcavaney

clmcavaney commented Jul 26, 2026

Copy link
Copy Markdown
Author

Closing to re-invoke github actions

Verification

  • npm run yaml — clean
  • npm test — 5373 passing (32s)
  • npm run lint — clean
  • Fixtures regenerated with the project tool:
    mocha test/all.mocha.js --writetests --countries AU → only test/fixtures/AU-VIC-2026.json change as expected

@clmcavaney clmcavaney reopened this Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants