add intro reference to the accs editor function#14
Merged
Conversation
dshevtsov
approved these changes
Apr 14, 2026
Collaborator
Author
|
re-requesting review from @dshevtsov, since after discussions with @keharper i added some additional changes to the transformer |
keharper
approved these changes
Apr 15, 2026
…ard rails
- Extract _edit_schema and _convert_schema helpers in edit_paas/convert_paas
to eliminate duplicated one-liners
- Convert all inline Ruby -e strings to heredocs for readability
- Add rescue JSON::ParserError with clean error messages across all functions
- Add file existence checks in edit_accs and convert_accs
- Add info key validation in edit_accs and _edit_schema; remove silent || {} fallbacks
- Fix unquoted $VERSION in convert_paas output paths
- Update edit_accs comment to reflect full scope of changes
Add missing title and version entries to the metadata list, update description bullet to reference accs-intro.md, and note the release version prompt in the usage NOTE.
|
@jhadobe please check if this still works as expected after my changes. |
dshevtsov
changed the title
dshevtsov
approved these changes
Apr 15, 2026
Collaborator
Author
it still works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Adds an intro reference to an _includes file for ACCS schemas.
Adds an override to change the title to "Adobe Commerce as a Cloud Service"
Adds a prompt to update the version name
I've validated by generating a schema, added in this PR: AdobeDocs/commerce-webapi#555
@dshevtsov notes: