Conversation
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#25 added these fields directly to
schemas/product.jsonby hand, but never updated the Zod source thatgenerate-schemas.tsuses to produce that file. Runningnpm run generate:json-schemason currentdevelopsilently deletes all 7 fields, since nothing in CI regenerates and diffs the committed schema against the Zod source. Verified this by running the generator before making any change — it removed the fields cleanly, no errors.How
Added the same 7 fields to
ProductCoreSchema(allz.string(), optional via the existing.partial()), then rannpm run generate:json-schemas. Resultingschemas/product.jsonhas the same field names/descriptions/types as #25 intended, minus some malformed"value": {}artifacts from the original hand-edit (not a valid JSON Schema keyword, inert either way) and one typo fix ("Freigth" → "Freight").Testing
npm run typecheck— cleannpm run lint— 0 errors (pre-existing warnings only, none in touched files)npm test— 224/224 passing