feat: Untangle some logic#196
Open
commonpike wants to merge 10 commits intodevelopfrom
Open
Conversation
added 9 commits
May 3, 2026 10:51
Post does not belong to platform or source, but to both
.. call post.prepare directly
- aligns with post.publish - post.prepare now calls platform.preparePost instead of vv
commonpike
commented
May 3, 2026
commonpike
commented
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In general, move the responsibility of post actions to the post model, so the Platform models become simpler.
The post is not a simple child of a platform, it is a join of a platform and a source. Also, models should not have static methods.
PostFactory.resolve(platform,source)instead ofstatic Post.getPostand Platform.getPost or Source.getPost mess. A post does not belong to a platform or a source, but to both