PDJB-928: Fix EPC inset showing on definite out of date EPCs#1400
Open
samyou-softwire wants to merge 1 commit into
Open
PDJB-928: Fix EPC inset showing on definite out of date EPCs#1400samyou-softwire wants to merge 1 commit into
samyou-softwire wants to merge 1 commit into
Conversation
a81baf3 to
ae69eeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number
PDJB-928
Goal of change
fix EPC inset showing on EPCs that were said to be out of date on property start

this inset should not be shown - the EPC is not 'maybe' valid
Description of main change(s)
noticed this deviation to the agreed behaviour. adds this check to the getInsetViewModel to make it show at the right time
Checklist
Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done
and any related functionality)