Skip to content

PDJB-928: Fix EPC inset showing on definite out of date EPCs#1400

Open
samyou-softwire wants to merge 1 commit into
mainfrom
fix/PDJB-928-fix-epc-inset-on-expired-not-valid-properties
Open

PDJB-928: Fix EPC inset showing on definite out of date EPCs#1400
samyou-softwire wants to merge 1 commit into
mainfrom
fix/PDJB-928-fix-epc-inset-on-expired-not-valid-properties

Conversation

@samyou-softwire
Copy link
Copy Markdown
Contributor

@samyou-softwire samyou-softwire commented Jun 2, 2026

Ticket number

PDJB-928

Goal of change

fix EPC inset showing on EPCs that were said to be out of date on property start
compliance actions with one expired epc with the EPC inset

this inset should not be shown - the EPC is not 'maybe' valid

Description of main change(s)

noticed this deviation to the agreed behaviour. adds this check to the getInsetViewModel to make it show at the right time

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Unit tests for new logic (e.g. new service methods) have been added
  • Single page integration tests have been added for any unhappy-flow UI features, e.g. validation errors
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket)

@samyou-softwire samyou-softwire self-assigned this Jun 2, 2026
@samyou-softwire samyou-softwire force-pushed the fix/PDJB-928-fix-epc-inset-on-expired-not-valid-properties branch from a81baf3 to ae69eeb Compare June 2, 2026 14:10
@samyou-softwire samyou-softwire marked this pull request as ready for review June 2, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant