PDJB-NONE: add isExpired accessor for JL invitation#1401
Merged
samyou-softwire merged 3 commits intoJun 4, 2026
Conversation
TomHanmer29
approved these changes
Jun 4, 2026
Contributor
TomHanmer29
left a comment
TomHanmer29
left a comment
There was a problem hiding this comment.
Just want to clarify one bit of logic/naming but otherwise seems sensible!
TomHanmer29
requested changes
Jun 4, 2026
Contributor
There was a problem hiding this comment.
Just read Rowan's comments on #1402 and agree we should probably add some unit tests with edge cases for this :)
Contributor
Author
|
agree - product has clarified exactly how they want expiration to work so I'll get on this |
Contributor
Author
|
added some tests @TomHanmer29, based on this from product (if the invitation expiry date was 06/06)
|
TomHanmer29
approved these changes
Jun 4, 2026
Contributor
TomHanmer29
left a comment
TomHanmer29
left a comment
There was a problem hiding this comment.
Tiny comment on tests, but happy that this aligns with the product decision.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be used for PDJB-300 and other tickets dealing with expired invitations