Skip to content

PDJB-306: Add marked joint landlord flag#1406

Merged
samyou-softwire merged 3 commits into
mainfrom
feat/PDJB-306-add-marked-for-joint-landlord-flag
Jun 4, 2026
Merged

PDJB-306: Add marked joint landlord flag#1406
samyou-softwire merged 3 commits into
mainfrom
feat/PDJB-306-add-marked-for-joint-landlord-flag

Conversation

@samyou-softwire
Copy link
Copy Markdown
Contributor

@samyou-softwire samyou-softwire commented Jun 4, 2026

Ticket number

PDJB-306 (and others in the future)

Goal of change

adds a database column that tracks whether the user indicated this is a JL property

right now filled in from the outcome of this question on the registration journey

invite joint landlords question

this will be used later on for designs where the landlord needs to specifically state later on that the property has no joint landlords

Description of main change(s)

adds database column

adds hooks into the journey flow to populate it

view of database

For reviewer

nothing here except the population of the field is feature flagged. I think this is fine as the default 'false' will be true for any registrations made before we turn on JL

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Unit tests for new logic (e.g. new service methods) have been added
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket) (nothing to QA yet, this is an internal change)

@samyou-softwire samyou-softwire self-assigned this Jun 4, 2026
@samyou-softwire samyou-softwire force-pushed the feat/PDJB-306-add-marked-for-joint-landlord-flag branch 2 times, most recently from 56a3d1e to 234db1e Compare June 4, 2026 09:25
@samyou-softwire samyou-softwire force-pushed the feat/PDJB-306-add-marked-for-joint-landlord-flag branch from 234db1e to d94b209 Compare June 4, 2026 09:36
Copy link
Copy Markdown
Contributor

@TomHanmer29 TomHanmer29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me! I think false by default is a good state for this to be in

@samyou-softwire samyou-softwire marked this pull request as ready for review June 4, 2026 09:49
@samyou-softwire samyou-softwire enabled auto-merge June 4, 2026 09:49
@samyou-softwire samyou-softwire added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit 68fca73 Jun 4, 2026
8 checks passed
@samyou-softwire samyou-softwire deleted the feat/PDJB-306-add-marked-for-joint-landlord-flag branch June 4, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants