PDJB-302: Remove (hide) expired invites#1408
Draft
samyou-softwire wants to merge 3 commits into
Draft
Conversation
move to having a status for JL invites rather than a series of flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket number
PDJB-302
Goal of change
allow for expired invites to be removed from the expired invites list
Description of main change(s)
implemented this as a column on an invite - as I understand we should never permanently remove invites, for auditing reasons
adds a notification box based on a flash
adds a new status property to an invitation to make it clear how to use the flags and make it natural to exclude deleted invites
Checklist
Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done
and any related functionality)
mention that here