Skip to content

Feat/pdjb 1039 joint landlord standalone flow#1410

Draft
TomHanmer29 wants to merge 3 commits into
mainfrom
feat/PDJB-1039-joint-landlord-standalone-flow
Draft

Feat/pdjb 1039 joint landlord standalone flow#1410
TomHanmer29 wants to merge 3 commits into
mainfrom
feat/PDJB-1039-joint-landlord-standalone-flow

Conversation

@TomHanmer29
Copy link
Copy Markdown
Contributor

Ticket number

PDJB-1039

Goal of change

Make a standalone version of the add a joint landlord flow

Description of main change(s)

Adds a standalone version of the add joint landlord flow with it's own CYA page and confirm page.
Also includes 2 new/updated email templates
Refactors the task to make the existing journey still work and reduce duplication

Anything you'd like to highlight to the reviewer?

see comments

Checklist

Delete any that are not applicable, and add explanation below for any that are applicable but haven't been done

  • Screenshots of any UI changes have been added
  • Unit tests for new logic (e.g. new service methods) have been added
  • Controller tests for any new endpoints, including testing the relevant permissions
  • Single page integration tests have been added for any unhappy-flow UI features, e.g. validation errors
  • New journey steps have been added to the appropriate journey integration test(s)
  • A new journey integration test has been added for any new journeys
  • New email templates have been added to /src/main/kotlin/resources/emails/emailTemplates.json
  • Test suite has been run in full locally and is passing
  • Branch has been rebased onto main and run locally, with everything working as expected (both for your new feature
    and any related functionality)
  • TODO comments referencing this JIRA ticket have been searched for and removed - if a future PR will address them,
    mention that here
  • Any special release instructions (e.g. the database will need resetting) have been added as checklist items to a draft PR (merging
    main into test) for the next release
  • QA instructions have been added to the ticket (particularly if this is the last PR required to complete the ticket)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant