feat(content): implement manifest installation instructions execution and GeneralsOnline EAC registration - #399
Merged
Conversation
undead2146
force-pushed
the
feat/installation-instructions-service
branch
from
August 19, 2026 14:49
2082054 to
e4e493b
Compare
Collaborator
|
non windows still fails with "requires administrator elevation, which is only supported on Windows" HttpContentDeliverer should probably become its own PR - It's unrelated to installation instructions, it alters behavior for all HTTP content acquisition, and like half the blocking findings from bots on this PR. |
…horization, and handle EAC registry exceptions
Member
Author
|
Thanks @bobtista! Updates in this revision:
All 2,061 Core tests, Linux tests, and the full CI build matrix (Windows, Linux, macOS, Smoke Test, Kilo Review) are 100% passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the manifest installation instructions execution engine and configures Easy Anti-Cheat (EAC) product registration as a post-acquisition installation step on GeneralsOnline game client manifests, resolving issue #342.
Motivation & Solution
GeneralsOnline requires registration of the EAC product ID (
fc1cc0d936424212b645105f084d08b0) viaEasyAntiCheat_EOS_Setup.exepost-acquisition. To futureproof against arbitrary/malicious execution while ensuring clear UX and update idempotency:RunVerifiedInstaller,RemoveFile,RenameFile).IInstallationInstructionsServiceenforcing publisher trust boundaries, workspace path containment viaPathHelper.IsPathContainedIn, and manifest file declaration + SHA-256 hash verification before execution.INotificationServiceclearly communicating step execution.RunOnce/StepKeystate persistence inUserSettingsand detection logic so users cleanly skip the installation step on updates if already executed.Changes
InstallationStepKindenum.InstallationStepto typed model withKind,TargetRelativePath,DestinationRelativePath,Arguments,RequiresElevation,StatusMessage,StepKey, andRunOnce.IContentManifestBuilderandContentManifestBuilder.IsPathContainedInandNormalizeRelativePathtoPathHelper.ExecutedInstallationStepscollection and helper methods toUserSettings.IInstallationInstructionsServicecontract.InstallationInstructionsServicewith publisher allowlisting (TrustedExecutablePublishers), path containment verification, file integrity checks, user notifications, async execution, andRunOnceupdate skipping.IInstallationInstructionsServiceintoBaseContentProvider.PrepareContentAsyncand all 8 derived content providers.FileSystemDelivererandHttpContentDelivererto preserveInstallationInstructions.GeneralsOnlineManifestFactoryto declare the EAC post-install step on 60Hz GameClient manifests whenEasyAntiCheat_EOS_Setup.exeis present.InstallationInstructionsServiceTestscovering security checks, hash verification, notifications, step execution,RunOnceskipping, and force bypass.GeneralsOnlineManifestFactoryEacTests,BaseContentProviderTests,GitHubContentProviderTests,ContentManifestBuilderTests, andPathHelperTests.Verification
Closes #342