add JET static analysis to test suite - #20
Merged
Merged
Conversation
Add JET as a test-only dependency and run report_package in an informational (non-blocking) testset, so JET surfaces regressions without failing CI on inference-limitation false positives. Fix three genuine latent bugs JET caught in untested code paths: - Rectangle negation called `verices` (typo for `vertices`). - discretize(::ExteriorRegion) referenced a nonexistent `ConnectedRegion`; dispatch to the generic AbstractConnectedRegion method via invoke (ExteriorRegion already has outerboundary == nothing). - refine_discretization used `z` after its while loop without binding it outside the loop body. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JET as a test-only dependency and run report_package in an informational (non-blocking) testset, so JET surfaces regressions without failing CI on inference-limitation false positives.
Fix three genuine latent bugs JET caught in untested code paths:
verices(typo forvertices).ConnectedRegion; dispatch to the generic AbstractConnectedRegion method via invoke (ExteriorRegion already has outerboundary == nothing).zafter its while loop without binding it outside the loop body.