Build Rectangle negation via canonical constructor - #23
Merged
Conversation
Negating a Rectangle went through the lowercase rectangle(-vertices(r)) builder, while every other arithmetic op uses Rectangle(center, radii, rotation) directly. Negation is a point reflection through the origin: center -> -center, radii and rotation unchanged (the vertex-offset set is closed under negation), so it can use the canonical constructor too. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Negating a
Rectanglewent through the lowercaserectangle(-vertices(r))builder, while every other arithmetic op (+/-with a scalar) uses the canonicalRectangle(center, radii, rotation)constructor directly.Negation is a point reflection through the origin:
center -> -center, withradiiandrotationunchanged (the vertex-offset set is closed under negation). So it can use the canonical constructor too, making the arithmetic operations internally consistent. Verified the result has identical vertices to the previous implementation.🤖 Generated with Claude Code