Skip to content

Responses to referee 1 - #40

Merged
tobydriscoll merged 5 commits into
mainfrom
jcon-ref1
Jun 29, 2026
Merged

Responses to referee 1#40
tobydriscoll merged 5 commits into
mainfrom
jcon-ref1

Conversation

@tobydriscoll

Copy link
Copy Markdown
Member

Based on comments from a paper reviewer.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/thiele.jl 16.66% 5 Missing ⚠️
src/barycentric.jl 66.66% 1 Missing ⚠️
src/parfrac.jl 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark Results

Ratios above 1 mean this PR is slower than main.

main 81b4b56... main / 81b4b56...
approximate/aaa/abs_circle 0.0454 ± 0.0014 s 0.0461 ± 0.0016 s 0.986 ± 0.046
approximate/aaa/exp_interval 0.148 ± 0.027 ms 0.143 ± 0.032 ms 1.03 ± 0.29
approximate/aaa/tanh_steep 1.66 ± 0.07 ms 1.63 ± 0.071 ms 1.02 ± 0.061
approximate/thiele/abs_circle 4.97 ± 0.04 ms 4.96 ± 0.038 ms 1 ± 0.011
approximate/thiele/exp_interval 0.0983 ± 0.0041 ms 0.0975 ± 0.0044 ms 1.01 ± 0.062
approximate/thiele/tanh_steep 0.244 ± 0.013 ms 0.242 ± 0.013 ms 1.01 ± 0.075
approximate_discrete/aaa/abs_shift 4.06 ± 0.06 ms 4.07 ± 0.066 ms 0.997 ± 0.022
approximate_discrete/aaa/sin_recip 1.36 ± 0.028 ms 1.37 ± 0.03 ms 0.992 ± 0.03
approximate_discrete/aaa/tanh_steep 11.9 ± 0.47 ms 12 ± 0.46 ms 0.991 ± 0.055
approximate_discrete/thiele/abs_shift 0.271 ± 0.028 ms 0.271 ± 0.026 ms 0.998 ± 0.14
approximate_discrete/thiele/sin_recip 0.139 ± 0.014 ms 0.139 ± 0.014 ms 1 ± 0.14
approximate_discrete/thiele/tanh_steep 0.927 ± 0.097 ms 0.929 ± 0.096 ms 0.998 ± 0.15
evaluate/bary_vector 0.142 ± 0.0069 ms 0.148 ± 0.0066 ms 0.954 ± 0.063
evaluate/thiele_vector 0.0905 ± 0.00062 ms 0.107 ± 0.00077 ms 0.843 ± 0.0084
poles/thiele 0.42 ± 0.014 ms 0.422 ± 0.018 ms 0.997 ± 0.054
time_to_load 0.887 ± 0.0049 s 0.888 ± 0.0069 s 0.998 ± 0.0095

Benchmark Plots

Plots have been uploaded as an artifact to this workflow run
("Actions" -> this run -> "Artifacts" at the bottom).

@tobydriscoll
tobydriscoll merged commit 25af6af into main Jun 29, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant