JET analysis - #41
Merged
Merged
Conversation
Two genuine UndefVarErrors found by JET's report_package: - abstract-rational.jl: the `nodes`/`values` interface stubs referenced an undefined `r` in their error message (arg was unnamed `::Abstract...`), so the fallback threw `UndefVarError(:r)` instead of the intended "not implemented" message. Name the argument `r`. - aaa.jl: the continuum `aaa(f; stats=true)` branch referenced the nonexistent `ConvergenceStats` type and passed an unsupported `stats` kwarg to `Barycentric`, so `stats=true` always errored. Return a stats named tuple instead, mirroring the discrete `aaa(y, z; stats=true)`. The remaining JET reports are known false positives (broadcasting's `getfield(::Broadcasted, ::Symbol)` and a chain through GenericLinearAlgebra's generic `svd`). Full test suite (927 tests) passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Benchmark ResultsRatios above 1 mean this PR is slower than
Benchmark PlotsPlots have been uploaded as an artifact to this workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependency and fix minor bugs unearthed by JET analysis