Changing defaults and calling sequences - #44
Merged
Conversation
AirspeedVelocity runs the PR's benchmark script against the base revision as well as the PR head, so the script cannot use syntax introduced on this branch. Select the call form once at load time from what the loaded package supports. The deprecated `method=` keyword is not used as a common dialect because its depwarn fires with force=true on every call, which would skew the timings being compared. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Benchmark ResultsRatios above 1 mean this PR is slower than
Benchmark PlotsPlots have been uploaded as an artifact to this workflow run |
The new max_degree=100 default caps the continuum Barycentric iteration below what abs(x) needs: it stagnates naturally at degree 116, so the default truncates it 16 degrees early and leaves only a 37x margin under the test's atol=1e-10 -- enough to pass on macOS/arm and fail on ubuntu-x64. Requesting max_degree=150 lets both cases converge, restoring a 640x margin. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
quitting_check returned an Int carrying three overloaded meanings, so a run that exhausted its degree budget was indistinguishable from one that stagnated -- the reason the abs(x) tolerance failure read as a mystery. Four call sites also had to pass a fake max_iter=1 to reach the "pick the best iterate" branch for failures unrelated to the budget. Split the check into a (reason, best) tuple plus a callable best_acceptable, and record the outcome in a ConvergenceStatus stored on the approximation, reachable via status(r) and isconverged(r). The fallback when no iterate has acceptable poles is now explicit rather than relying on a loop falling through with n unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow=:strictfor old behavior..notation for an interval