Fix array evaluation at nodes - #45
Merged
Merged
Conversation
The array method decided that a point was a node by testing whether 1/(z - node) had overflowed to Inf. That misses a node in the complex plane, where 1/(0+0im) is NaN+NaN*im rather than Inf, and it misses a real node whose value is zero, where the numerator is 0/0 instead. Both returned NaN where the scalar method interpolates. Compare against the nodes instead, and while here, give an infinite argument the same limit the scalar method takes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Benchmark ResultsRatios above 1 mean this PR is slower than
Benchmark PlotsPlots have been uploaded as an artifact to this workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture infinite inputs, and nodal inputs for Barycentric.