fix: harden workflow token permissions and pin yamllint - #218
Merged
marcusburghardt merged 7 commits intoSep 4, 2026
Merged
Conversation
marcusburghardt
requested review from
gxmiranda,
jflowers and
jpower432
as code owners
September 4, 2026 14:39
marcusburghardt
force-pushed
the
fix/security-workflow-permissions
branch
from
September 4, 2026 14:43
72042b5 to
482548e
Compare
Add a top-level 'permissions: contents: read' block to restrict the default GITHUB_TOKEN scope and pin yamllint to v1.38.0 to satisfy the Pinned-Dependencies check. Resolves code scanning alerts: complytime#35, complytime#36, complytime#51 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Add a restrictive top-level 'permissions: contents: read' block to ensure the default GITHUB_TOKEN scope is minimal. The existing job-level permissions block is preserved as an explicit override. Resolves code scanning alert: complytime#33 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Add a restrictive top-level 'permissions: contents: read' block to ensure the default GITHUB_TOKEN scope is minimal. The existing job-level permissions block (contents: read, issues: write) is preserved as an explicit override for the drift detection job. Resolves code scanning alert: complytime#34 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Add persist-credentials: false to the actions/checkout step to prevent unnecessary git credential storage on disk. Resolves zizmor artipacked finding. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Add persist-credentials: false to both actions/checkout steps to prevent unnecessary git credential storage on disk. Resolves zizmor artipacked findings. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Add persist-credentials: false to both actions/checkout steps to prevent unnecessary git credential storage on disk. Resolves zizmor artipacked findings. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Peribolos manages the entire complytime GitHub org (membership, teams, repos), so its GitHub App token intentionally requires org-wide scope. The zizmor github-app audit flags this as dangerous, but scoping the token to individual repositories would break peribolos functionality. Resolves zizmor github-app findings. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
fix/security-workflow-permissions
branch
from
September 4, 2026 15:00
482548e to
4ca2959
Compare
Member
Author
|
After the initial approval, I rebased onto the latest upstream/main and added 4 follow-up commits to fix zizmor lint failures surfaced by MegaLinter (pre-existing issues in the touched files, not introduced by the original changes):
|
marcusburghardt
enabled auto-merge (rebase)
September 4, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add restrictive top-level
permissionsblocks to three peribolosworkflows to minimize the default GITHUB_TOKEN scope, and pin the
yamllintdependency to a specific version.Changes
permissions: contents: readatworkflow level and pin
yamllint==1.38.0permissions: contents: read(existing job-level permissions preserved)
permissions: contents: read(existing job-level
contents: read+issues: writepreserved)Code Scanning Alerts Resolved