Open
Conversation
lib/adapter.js
Outdated
Contributor
There was a problem hiding this comment.
Use a for loop without shift to improve performance.
Contributor
|
Any prior art with other view/bindings frameworks and what they do? This seems like a reasonable feature. |
Contributor
|
👍 lgtm |
Contributor
|
Can merge after tests added. |
defunctzombie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get()ing nested properties using dot-notation works, so it seems logical that it should work duringset()as well. I needed it today, so implemented it.It behaves like a
mkdir -p, creating objects along the path if they don't exist. The other option is to throw in error in that case. I haven't thought through the pros/cons of each.If this is a desired feature, I'll happily add some tests & polish it up.
EDIT: fixed a bug