Open
Conversation
Contributor
Author
|
It should be noted that I ran the full test suite and got a pass: |
Contributor
|
Yea, automatic travis CI tests never work because of the secure ENV variables in the travis config. |
Contributor
|
This is brilliant. I will review in more detail tonight and merge. |
Contributor
Author
|
the latest commit updates to a simpler set of shims (version 0.1.2 of reactive-ie8-shims). It removes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have successfully gotten a full pass in IE8 for reactive. To do so, I needed to include #158, make some small adjustments to tests and code, and include a ton of shims. I did this by creating a separate repository: reactive-ie8-shims, which can be included via browserify or prebuilt scripts. Simply shim it in before running any reactive code and you're golden!