Skip to content

Bafna.Mihir - #2

Open
MihirBafna wants to merge 2 commits into
compvision:masterfrom
MihirBafna:master
Open

Bafna.Mihir#2
MihirBafna wants to merge 2 commits into
compvision:masterfrom
MihirBafna:master

Conversation

@MihirBafna

Copy link
Copy Markdown

No description provided.

@MihirBafna

Copy link
Copy Markdown
Author

the program asks the user to provide the actual width of the target, and the threshold values through input

@RobertYL

RobertYL commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Rubric:
Detection - [30%] Good.
Analysis - [20%] Good.
Structure - [20%] Nice!
Naming Convention - [10%] Variable names aren't as descriptive as they should be.
Documentation - [10%] Did not comment variables. Also, make sure to place the function comments before the first line. You don't need to place it to the right of the line.

Overall: 90%
Pass. I would like you to re-submit with corrected comments and better variable names but this is acceptable.

@RobertYL

RobertYL commented Nov 1, 2018

Copy link
Copy Markdown
Contributor

Documentation - [15%] Excellent! Comprehensive explanations for each variable.

Overall: 95%
Pass. Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants