Skip to content

fix: resolve assigned stream and CI issues - #406

Merged
Jaydbrown merged 2 commits into
conduit-protocol:mainfrom
0takuc0mrade:fix/assigned-stream-and-ci-issues
Aug 31, 2026
Merged

fix: resolve assigned stream and CI issues#406
Jaydbrown merged 2 commits into
conduit-protocol:mainfrom
0takuc0mrade:fix/assigned-stream-and-ci-issues

Conversation

@0takuc0mrade

Copy link
Copy Markdown
Contributor

Summary

Verification

  • npm ci
  • npm run lint
  • npm run typecheck
  • npm test (413 passed, 4 todo)
  • npm run build

Fixes #374
Fixes #375
Fixes #376
Fixes #404

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@0takuc0mrade Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mhikel66

Copy link
Copy Markdown
Contributor

Heads-up: fixing the lockfile is necessary but not sufficient for a green npm ci. @conduit-protocol/sdk is a git dependency with a prepare build, and conduit-protocol/streamFi-sdk main currently doesn't compile — its #498 merge reintroduced _signer(): Signer without the Signer type import (TS2304). So npm ci fails at the SDK's prepare step regardless of registry URLs. That's fixed in conduit-protocol/streamFi-sdk#555 — this repo's CI needs both.

@Jaydbrown

Copy link
Copy Markdown
Contributor

This branch is far behind main — merging it produces 10 conflicting files (package.json/package-lock.json, contexts/WalletContext.tsx, .github/workflows/ci.yml, app/stream/[id]/page.tsx, the test suite) and a 40-file / ~600-line divergence, reverting the shared withTimeout extraction and the #363 recipient-check test scaffolding. Needs a fresh rebase onto current main. Leaving open per instruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment