feat: resolved frontend issues - #433
Merged
Merged
Conversation
…unt state leaks (conduit-protocol#368) The singleton gateway keyed records by token+spender only, so switching wallet accounts could return the previous account's cached allowance, potentially skipping the approve step and causing create_stream to revert. - Change _key to owner::token::spender triple - Update _getOrCreate, getAllowance, approve, checkAllowance accordingly - Call resetTokenAllowanceGateway() on disconnect and account switch in WalletContext (same places that call queryClient.clear())
…() (conduit-protocol#367) reset() was resolving queued concurrency entries (calling entry() which resolved the waiter with a release function), causing approve() calls to proceed against a disconnected wallet after reset was called on disconnect. - Restructure queue entries to store { resolve, reject } callbacks - Call entry.reject(OperationAbortedError) during reset drain - Matches the comment's intended behavior: queued waiters are rejected
…onduit-protocol#365, conduit-protocol#366) conduit-protocol#365 - N+1 serial fetch: - Resolve all stream addresses in one Promise.allSettled batch - Fetch info+withdrawable in bounded-parallel batches of 5 - Debounce visibilitychange refetch: skip if last fetch was <5s ago conduit-protocol#366 - Silent data loss on fetch errors: - Collect per-stream failures via failedCount in loadRows return - Show amber partial-error banner when some streams fail to load (e.g. '3 streams could not be loaded — some data may be missing') with a Retry button, distinguishing partial failure from empty result
|
@0xSlink Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #368 — Key TokenAllowanceGateway records by owner::token::spender; call resetTokenAllowanceGateway() on disconnect/account-switch
Closes #367 — Concurrency queue entries store { resolve, reject }; reset() calls entry.reject(OperationAbortedError)
Closes #365
Closes #366 — Parallelize stream fetches (address batch + info/withdrawable in batches of 5); debounce visibility refetch (5s); surface partial errors with amber banner