fix(lib): defer unsafe updates and clean stale UI paths (#424) - #436
Open
Mekussdev wants to merge 6 commits into
Open
fix(lib): defer unsafe updates and clean stale UI paths (#424)#436Mekussdev wants to merge 6 commits into
Mekussdev wants to merge 6 commits into
Conversation
Add regression coverage for service-worker reload safety, indexer availability errors, and the theme cycle so the assigned fixes are guarded before implementation.
Controller changes can arrive while a wallet operation is signing, broadcasting, or confirming. Check the transaction store before reloading and wait for active transactions to settle so update activation does not interrupt in-flight work. Closes conduit-protocol#424
The app defaults to following the OS theme, but the navbar toggle previously pinned users to light or dark forever. Cycle dark back to system so users can return to follow-OS mode from the visible control. Closes conduit-protocol#426
The app already mounts react-hot-toast and no code dispatches the custom notification event. Removing the unreferenced component and test avoids keeping a second notification system that never runs. Closes conduit-protocol#425
A configured non-demo deploy currently has no transaction-history indexer, which is an expected unavailable state rather than a fetch failure. Use a typed availability error so the page can skip pointless retries and render a neutral coming-soon message while keeping real failures in the error path. Closes conduit-protocol#427
Record the service-worker, notification, theme, and transaction-history fixes under Unreleased after typecheck, lint, tests, and build passed locally.
|
@Mekussdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
This branch is ~45 files behind |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checks
Notes
Closes #424
Closes #425
Closes #426
Closes #427