fix(#387,#400,#402,#398): invert demo-history ternary, validate strea… - #440
Merged
Conversation
…nduit-protocol#398): invert demo-history ternary, validate stream id, graceful withdrawable fallback, cap RateTicker at endTime - conduit-protocol#387: flip fetchTransactionHistory ternary so demo data returns only when no publicKey is connected, not for real wallets - conduit-protocol#400: validate URL segment against /^\d+$/ before BigInt() to prevent raw SyntaxError surfacing to the user - conduit-protocol#402: load getStreamInfo first, then fetch getWithdrawable separately with independent error handling so a withdrawable failure doesn't block the entire detail page (both initial load and background refresh) - conduit-protocol#398: add endTime prop to RateTicker and cap elapsed seconds so the live counter freezes at the stream's end instead of ticking past the contract balance
|
@BaseDev-Eth Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #387 lib/indexer.ts:77 Flipped ternary: publicKey ? [] : DEMO_TXS — demo data now only shows for placeholder mode (no wallet), not for real users
Closes #400 app/stream/[id]/page.tsx:80 Added /^\d+$/ validation before BigInt(id) — non-numeric IDs show "Invalid stream ID" instead of raw SyntaxError
Closes #402 app/stream/[id]/page.tsx:89-100,118-131 Replaced Promise.all with sequential loading — stream info loads first (core content), withdrawable fetches independently with its own catch block so a timeout/rate-limit doesn't block the detail view
Closes #398 components/stream/RateTicker.tsx:14,39-46 Added endTime prop; elapsed seconds are capped at endTime - startRef.ts so the live counter freezes at the stream's end instead of ticking past the contract balance