fix: surface toast on refreshStreamData failure - #442
Open
martinshub-tech wants to merge 1 commit into
Open
Conversation
|
@martinshub-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #354
Description
This PR addresses an issue where
refreshStreamDatawas failing silently without any user-facing feedback. Previously, whenrefreshStreamDatawas called after a successful transaction (fromlib/store.ts) and the invalidation/refetch failed, it only emitted aconsole.warn. As a result, the UI continued to show pre-transaction balances and stream states with no indication that something went wrong.This update introduces a
toast.errorwithin the catch block ofrefreshStreamDatato explicitly inform the user that the data refresh failed, and provides a manual-refresh affordance by instructing them to refresh the page.Changes Made
react-hot-toastintolib/queryClient.ts.toast.errornotification to surface a visible error message (Failed to refresh data. Please refresh the page manually.) if thePromise.allquery invalidation fails.