fix: freeze cancelled stream progress bar at mount time - #517
Open
Obetaebube3 wants to merge 1 commit into
Open
Conversation
|
@Obetaebube3 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #417
This PR fixes a bug where a cancelled stream's progress bar and percentage label would keep creeping toward 100% every time the page re-rendered or was reloaded.
Because the contract's
StreamInfodoes not currently expose acancelled_attimestamp, this PR implements the fallback behavior of freezing the progress atmin(now, endTime)captured exactly once when the component mounts.Changes
StreamProgressBar.tsxmountTimeRefto capture the exact wall-clock time when the component mounts.referenceMscalculation to freeze atMath.min(mountTime, endTime)for cancelled streams, preventing the CSS animation width from creeping forward.referenceSecstate to also freeze for cancelled streams, fixing thearia-valuenowaccessibility attribute.StreamCard.tsx"use client"directive.mountSecstate initialized at mount time (Date.now() / 1_000).pctSnapshotlogic for cancelled streams to freeze atMath.min(mountSec, endTime), preventing the text percentage label from climbing on subsequent renders.Testing
endTime === 0) are properly handled withoutNaNor incorrect progress.