Fix paused-stream clawback bypass - #475
Open
babawo96 wants to merge 1 commit into
Open
Conversation
## Summary This patch blocks `clawback()` while a stream is paused, preventing the sender from freezing accrual and immediately draining the remaining principal while the recipient is unable to earn any additional funds. ## Root cause `streamed_amount()` freezes accrual at `paused_at`, so a paused stream reports a tiny `owed` amount. The previous `clawback()` logic then reclaimed `balance - owed`, which could be effectively the entire remaining principal in the same block the sender paused the stream. ## Fix - reject `clawback()` when `info.is_paused()` is true - require `resume()` before sender/operator may claw back any unstreamed funds - add the paused-stream regression assertion to the clawback tests - document the resume-first behavior in the contract docs ## Notes Per the request, this change was made without running tests or compilation checks in this session, so CI status is not claimed here.
|
@babawo96 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #369
Summary
This patch blocks
clawback()while a stream is paused, preventing the sender from freezing accrual and immediately draining the remaining principal while the recipient is unable to earn any additional funds.Root cause
streamed_amount()freezes accrual atpaused_at, so a paused stream reports a tinyowedamount. The previousclawback()logic then reclaimedbalance - owed, which could be effectively the entire remaining principal in the same block the sender paused the stream.Fix
clawback()wheninfo.is_paused()is trueresume()before sender/operator may claw back any unstreamed fundsNotes
Per the request, this change was made without running tests or compilation checks in this session, so CI status is not claimed here.