Fix #416: Deduplicate stream addresses in cancel_batch_streams - #478
Open
chiemezie1 wants to merge 1 commit into
Open
Fix #416: Deduplicate stream addresses in cancel_batch_streams#478chiemezie1 wants to merge 1 commit into
chiemezie1 wants to merge 1 commit into
Conversation
…h_streams Issue conduit-protocol#416: cancel_batch_streams didn't deduplicate stream_addresses, causing panics when a duplicated address was passed. If a caller accidentally passes the same stream address twice (e.g., building the list from an unfiltered selection), the first cancel succeeds and sets FLAG_CANCELLED. The second cancel on the now- cancelled stream returns Error::StreamCancelled, which the generated non-try_ DripStreamClient::cancel turns into a panic, reverting the entire batch. Solution: Deduplicate stream_addresses before cancelling. Each unique stream is cancelled exactly once, degrading accidental duplicates to a no-op for that entry instead of failing the whole batch. Changes: - Add deduplication logic in cancel_batch_streams to build unique_addresses - Add regression tests in tests/factory_batch_cancel.rs: * regression_duplicate_stream_addresses_cancel_without_panic: Simulates the dedup behavior with duplicate addresses * stream_cancel_twice_fails_gracefully: Verifies the underlying behavior that causes the batch failure
|
@chiemezie1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #416: Deduplicate stream addresses in cancel_batch_streams
Problem
DripFactory::cancel_batch_streamsdidn't deduplicatestream_addresses, causing panics when a duplicated address was passed.If a caller accidentally passes the same stream address twice (e.g., building the list from an unfiltered selection), the first cancel succeeds and sets
FLAG_CANCELLED. The second cancel on the now-cancelled stream returnsError::StreamCancelled, which the non-try_ variant turns into a panic, reverting the entire batch. Every other cancellation in the same call is rolled back.Solution
Deduplicate
stream_addressesbefore cancelling. Each unique stream is cancelled exactly once, degrading accidental duplicates to a no-op for that entry instead of failing the whole batch.Changes
cancel_batch_streams()to buildunique_addressesvectortests/factory_batch_cancel.rs:regression_duplicate_stream_addresses_cancel_without_panic: Simulates the dedup behavior with duplicate addressesstream_cancel_twice_fails_gracefully: Verifies the underlying behavior that causes batch failuresTesting
✅ All factory unit tests pass (32 passed)
✅ Regression tests pass (2 passed)
✅ No existing tests broken
Closes: #416