Fix event sequence persistence in stream config state - #479
Open
pchieneye wants to merge 1 commit into
Open
Conversation
|
@pchieneye Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stream event sequence persistence in config state
Summary
This fixes the event sequence persistence bug described in #394.
The root issue was that the sequence counter was persisted separately from the consolidated stream config state, so a future migration that removes legacy per-field storage keys could silently reset the counter and cause previously-used sequence numbers to be re-emitted. That breaks gap detection for consumers that rely on the monotonic event sequence.
This change:
Verification
I ran the targeted check:
source $HOME/.cargo/env && cd /workspaces/streamFi-contracts && cargo test -p drip-stream event_sequence_is_persisted_in_config_and_not_left_as_legacy_state -- --nocaptureThe build is currently blocked by unrelated, pre-existing compile errors in the stream contract referencing missing enum variants (
InvalidRecipient,BackdatedStream, andStreamUnderfunded). Those were left untouched per the task scope.Closing
Closes #394