Fix #417: Allow atomic operator replacement in set_operator - #481
Open
chiemezie1 wants to merge 1 commit into
Open
Fix #417: Allow atomic operator replacement in set_operator#481chiemezie1 wants to merge 1 commit into
chiemezie1 wants to merge 1 commit into
Conversation
…erator Issue conduit-protocol#417: set_operator couldn't replace an existing operator - it returned Error::OperatorAlreadySet instead of allowing the replacement. This required two transactions to rotate a compromised key: revoke_operator then set_operator, leaving a window where the stream has no operator. Solution: Modify set_operator to allow replacement while maintaining idempotent behavior for same-address calls. When a different operator is provided: - Emit operator_revoked event for the old address - Set the new operator and emit operator_set event - This provides atomic key rotation in a single transaction Changes: - Modify set_operator() in contracts/stream/src/lib.rs to allow replacement - Keep idempotent early-return for same-address calls - Emit both operator_revoked and operator_set events on replacement - Update tests to verify atomic replacement behavior - Add test for idempotent same-address calls - Add missing error variants to Error enum (InvalidRecipient, BackdatedStream, StreamUnderfunded) that were blocking compilation
|
@chiemezie1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: reject bounded streams whose total obligation overflows
Summary
Fixes #405 by rejecting bounded
DripStreaminitializations whose total obligation would overflowi128.Previously,
initialize()validated zero/negative rates and malformed time ranges, but it did not reject the case where:would overflow. That allowed a direct-initialized stream to be created in a state that later trapped settlement flows (
withdraw,cancel,clawback,force_cancel) withArithmeticOverflowafter enough ledger time elapsed, permanently locking the escrow.What changed
lib.rstests.rscovering the overflow caseVerification
I verified with:
Closing
Closes #417