Skip to content

Fix long-pause resume TTL regression - #482

Open
code-0-stella wants to merge 1 commit into
conduit-protocol:mainfrom
code-0-stella:bugfix/393-pause-ttl
Open

Fix long-pause resume TTL regression#482
code-0-stella wants to merge 1 commit into
conduit-protocol:mainfrom
code-0-stella:bugfix/393-pause-ttl

Conversation

@code-0-stella

Copy link
Copy Markdown

Fix long-pause resume path before instance storage archives

Summary

Prevents a paused stream from remaining resumable after the safe pause TTL window has elapsed.

This addresses the archive-risk where a stream is paused once, the instance TTL is extended, and the pause can then outlast the safe window without a manual restore. In that case, a normal resume() call can hit the host’s “entry archived” error path instead of failing gracefully with contract logic.

What changed

  • Added a single maximum safe pause threshold in the stream TTL module.
  • Reused that threshold in the resume guard and force-cancel logic so the protocol consistently rejects overlong pauses.
  • Added a regression test covering the resume-after-extended-pause case.

Why

A long pause can leave the stream instance storage effectively archived before the caller can recover it. The contract should fail with a clear, intentional PauseThresholdNotMet error instead of allowing the host to surface an opaque archival failure.

Verification

I added a focused regression test for this scenario. The workspace still contains unrelated existing compile errors outside this task, so I left those unchanged as requested.

Closes #393

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@code-0-stella Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant