Add operator withdrawal caps to token vault - #485
Open
pchieneye wants to merge 1 commit into
Open
Conversation
|
@pchieneye Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TokenVault operator withdrawal authority to enforce per-call limits
Summary
This fixes the issue described in #388.
TokenVaultcurrently allows a delegated operator to callwithdraw(caller, to, amount)for any destination and any amount up to the vault balance. That means a compromised hot key can drain the vault in a single transaction, which defeats the purpose of splitting owner and operator authority.This change introduces an owner-configurable cap for operator withdrawals while keeping owner withdrawals unbounded.
What changed
Verification
I ran the token-vault test suite:
source $HOME/.cargo/env && cd /workspaces/streamFi-contracts && cargo test -p token-vault -- --nocaptureResult:
This patch is scoped to the operator withdrawal limit fix and the targeted regression coverage for that behavior.
Closing
Closes #388