feat(stream): add total_streamed() view method to DripStream - #489
Open
chainsmt wants to merge 1 commit into
Open
feat(stream): add total_streamed() view method to DripStream#489chainsmt wants to merge 1 commit into
chainsmt wants to merge 1 commit into
Conversation
|
@chainsmt Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
total_streamed()as the canonical on-chain view for cumulative streamed tokens, delegating from the existingstreamed_total()alias so both symbols stay available.Also updates the frontend SDK to query
total_streamedand adds a unit test asserting parity withstreamed_totalafter elapsed time accrues.Includes missing
Errorenum variants (BackdatedStream,StreamUnderfunded,InvalidRecipient) already referenced bylib.rsonmainso the contract crate compiles for CI.Testing
cargo test total_streamedincontracts/stream→ 1 passedCloses #461