Reject far-future stream start times - #490
Open
code-0-stella wants to merge 2 commits into
Open
Conversation
|
@code-0-stella Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject far-future stream start times
Summary
Rejects stream creation when
start_timeis too far in the future, preventing the protocol from escrowing a full future deposit for a stream that will not begin for an extended period.This closes the gap where
create_streamalready rejectedstart_time < now, but still accepted far-future schedules. That allowed a sender to lock funds immediately with no meaningful accrual and no timely early exit beyond a manual cancel.What changed
start_time - nowbased on the governor’s configured maximum scheduling horizon.StartTimeTooFarInFuture.Why
A stream scheduled years in the future still escrows the full deposit immediately. That leaves funds idle, increases recipient index bloat risk, and creates a poor UX trap for users who expect the stream to begin promptly.
Verification
Verified with focused regression tests covering the far-future start-time cases on the fresh task branch.
Closes #395