Skip to content

Add issue #459 note - #491

Open
Ameer-5-5 wants to merge 1 commit into
conduit-protocol:mainfrom
Ameer-5-5:fixissue
Open

Add issue #459 note#491
Ameer-5-5 wants to merge 1 commit into
conduit-protocol:mainfrom
Ameer-5-5:fixissue

Conversation

@Ameer-5-5

Copy link
Copy Markdown

CLOSES #459

What does this PR do?

Type of change

  • Bug fix
  • New feature
  • Refactor (no behaviour change)
  • Test coverage
  • Documentation
  • Security fix

Related issue

Closes #

Changes

File Change

Checklist

  • cargo fmt --all — no diff
  • cargo clippy --all-targets -- -D warnings — zero warnings
  • cargo test --all — all tests pass
  • New public functions have tests covering the happy path and each error variant
  • All arithmetic uses checked_* methods
  • require_auth() called before any state mutation in modified functions
  • State mutations happen before cross-contract calls (token transfers)
  • Events emitted for all external state changes
  • CHANGELOG.md updated under [Unreleased]
  • docs/architecture.md updated if design changed
  • ADR written if a significant design decision was made

Security notes

Testing notes

@Ameer-5-5
Ameer-5-5 requested a review from Jaydbrown as a code owner August 31, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

logical_to_physical_offset has no fuzz coverage

1 participant