Skip to content

Fix: Propagate math errors instead of swallowing them in read-only views (#409) #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jaydbrown merged 1 commit into from
Aug 31, 2026
Merged

Fix: Propagate math errors instead of swallowing them in read-only views (#409) #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions contracts/stream/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,12 +585,12 @@ impl DripStream {
}

/// Read-only: current withdrawable balance for the recipient.
pub fn withdrawable(env: Env) -> i128 {
pub fn withdrawable(env: Env) -> Result<i128, Error> {
let info = state::load(&env);
if info.is_cancelled() {
return 0;
return Ok(0);
}
math::withdrawable(&env, &info).unwrap_or(0)
math::withdrawable(&env, &info)
}

/// Read-only: whether clawback is enabled for this stream.
Expand Down Expand Up @@ -743,12 +743,12 @@ impl DripStream {
///
/// Useful for UIs that want to show "X streamed, Y withdrawn, Z remaining"
/// without the caller needing to reimplement the rate × elapsed math.
pub fn streamed_total(env: Env) -> i128 {
pub fn streamed_total(env: Env) -> Result<i128, Error> {
let info = state::load(&env);
if info.is_cancelled() {
return 0;
return Ok(0);
}
math::streamed_amount(&env, &info).unwrap_or(0)
math::streamed_amount(&env, &info)
}

/// Read-only: full stream state.
Expand Down