fix: bound factory sender/recipient indices - #496
Open
pchieneye wants to merge 2 commits into
Open
Conversation
* feat: implement paginated indexing for streams by sender and recipient, update legacy storage handling * fix: update legacy index migration check and improve documentation for paged storage keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bound the factory sender/recipient indices to fixed-size pages instead of a single unbounded Vec that is rewritten on every
create_stream.What changed
BySenderandByRecipienthistory into bounded storage bucketsWhy
A single unbounded Vec per sender/recipient grows without bound and can eventually hit Soroban entry-size limits, which permanently breaks future stream creation for that address.
Testing
Closes #362