Skip to content

Refactor oracle TWAP aggregation to shared inner helpers - #498

Open
chidumebiodoh123-cloud wants to merge 1 commit into
conduit-protocol:mainfrom
chidumebiodoh123-cloud:fix/oracle-shared-aggregation
Open

Refactor oracle TWAP aggregation to shared inner helpers#498
chidumebiodoh123-cloud wants to merge 1 commit into
conduit-protocol:mainfrom
chidumebiodoh123-cloud:fix/oracle-shared-aggregation

Conversation

@chidumebiodoh123-cloud

@chidumebiodoh123-cloud chidumebiodoh123-cloud commented Aug 31, 2026

Copy link
Copy Markdown

Closes #391


What does this PR do?

Type of change

  • Bug fix
  • New feature
  • Refactor (no behaviour change)
  • Test coverage
  • Documentation
  • Security fix

Related issue

Closes #

Changes

File Change

Checklist

  • cargo fmt --all — no diff
  • cargo clippy --all-targets -- -D warnings — zero warnings
  • cargo test --all — all tests pass
  • New public functions have tests covering the happy path and each error variant
  • All arithmetic uses checked_* methods
  • require_auth() called before any state mutation in modified functions
  • State mutations happen before cross-contract calls (token transfers)
  • Events emitted for all external state changes
  • CHANGELOG.md updated under [Unreleased]
  • docs/architecture.md updated if design changed
  • ADR written if a significant design decision was made

Security notes

Testing notes

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@chidumebiodoh123-cloud Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@chidumebiodoh123-cloud

Copy link
Copy Markdown
Author

Closes #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant