Skip to content

fix(module49): prevent double-counting totalProcessed in processStreamBatch - #591

Open
smithd2423-beep wants to merge 1 commit into
conduit-protocol:mainfrom
smithd2423-beep:patch-1
Open

fix(module49): prevent double-counting totalProcessed in processStreamBatch#591
smithd2423-beep wants to merge 1 commit into
conduit-protocol:mainfrom
smithd2423-beep:patch-1

Conversation

@smithd2423-beep

@smithd2423-beep smithd2423-beep commented Aug 31, 2026

Copy link
Copy Markdown

Closes #571


What does this PR do?

Type of change

  • Bug fix
  • New feature / method
  • Refactor
  • Test coverage
  • Documentation
  • Dependency update

Related issue

Closes #

Changes

File Change

Checklist

  • npm run typecheck — no errors
  • npm run lint — no warnings
  • npm test — all tests pass
  • npm run build — bundle compiles cleanly
  • No any types introduced
  • New public methods documented in docs/api.md
  • All on-chain amounts kept as bigint — no Number() conversion in arithmetic
  • New methods mock-tested in src/tests/
  • CHANGELOG.md updated under [Unreleased]
  • src/index.ts updated if new exports added

Breaking changes?

  • No
  • Yes — describe below and add BREAKING CHANGE: footer to relevant commit

Notes for reviewers

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@smithd2423-beep Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Module49.processStreamBatch double-counts totalProcessed (loop + += items.length) — metrics off by 2x

1 participant