fix(nonce): reject queued entries in NonceManager on reset/destroy to… - #593
Open
martinshub-tech wants to merge 1 commit into
Open
fix(nonce): reject queued entries in NonceManager on reset/destroy to…#593martinshub-tech wants to merge 1 commit into
martinshub-tech wants to merge 1 commit into
Conversation
|
@martinshub-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #511
Fix
NonceManagerhangs duringreset()anddestroy()Description
This PR resolves an issue in
NonceManagerwhere calls toreset()ordestroy()could leave waitingacquire()calls hanging indefinitely. The previous implementation cleared thelockQueuewithout rejecting or resolving the queued entries, which orphaned them and caused their promises to never settle. Additionally,reset()employed an unbounded busy-wait, which could hang forever if the current lock holder never released it.Changes Made
destroy(): Now iterates through thelockQueueand explicitly rejects every queued entry with aNonceManager destroyederror before clearing the queue.reset():lockQueueand explicitly rejects every queued entry with aNonceManager reseterror before clearing the queue.Impact
Any caller currently awaiting
acquire()will now correctly receive a rejection when theNonceManageris reset or destroyed, rather than hanging forever.