fix(nonce): use exponential backoff in safeAcquire - #636
Open
wildanniam wants to merge 1 commit into
Open
Conversation
|
@wildanniam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NonceManager.safeAcquirefrom linear retry delays to exponential backoff (delayMs * 2 ** attempt)100, 200, 400backoff sequenceVerification
npm test— 74 test files passed, 1 skipped; 964 tests passed, 2 skippednpm run typechecknpm run lintnpm run buildgit diff --checkBaseline note
Initial verification against the previous
maincommit (3bdb66d) exposed 18 unrelated stale test failures, four existing typecheck errors, and two existing lint errors. Those results reproduced on a clean worktree and were not introduced by this change.Before opening this PR,
mainreceiveda020f5a(test(ci): fix lint, typecheck and stale tests on main). This branch was rebased onto that commit and the complete test, typecheck, lint, and build verification is now green.Risks / Notes
WebSocketRelayerbehavior remain outside this focused issueCloses #551