fix(streams): warn in browser when process is undefined (#574) - #637
Open
miriamisa022-cyber wants to merge 1 commit into
Open
Conversation
…ocol#574) warnV1Deprecated used a triple typeof guard that returned false (isDev = false) in browser bundles where process is not defined, silently swallowing all v1 deprecation warnings. Fix: use optional chaining — process?.env?.NODE_ENV !== 'production' — so the absence of process evaluates to undefined !== 'production' (true) and the warning fires unless the environment is provably production. Adds a regression test that verifies the optional-chaining expression evaluates to true when process is undefined, matching the semantics of a plain browser bundle.
|
@miriamisa022-cyber Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
warnV1Deprecated used a triple typeof guard that returned false (isDev = false) in browser bundles where process is not defined, silently swallowing all v1 deprecation warnings.
Fix: use optional chaining — process?.env?.NODE_ENV !== 'production' — so the absence of process evaluates to undefined !== 'production' (true) and the warning fires unless the environment is provably production.
Adds a regression test that verifies the optional-chaining expression evaluates to true when process is undefined, matching the semantics of a plain browser bundle.
What does this PR do?
Type of change
Related issue
Closes #
Changes
Checklist
npm run typecheck— no errorsnpm run lint— no warningsnpm test— all tests passnpm run build— bundle compiles cleanlyanytypes introduceddocs/api.mdbigint— noNumber()conversion in arithmeticsrc/tests/CHANGELOG.mdupdated under[Unreleased]src/index.tsupdated if new exports addedBreaking changes?
BREAKING CHANGE:footer to relevant commitNotes for reviewers
closes #574